Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix clippy #283

Merged
merged 9 commits into from
Nov 25, 2024
Merged

chore: fix clippy #283

merged 9 commits into from
Nov 25, 2024

Conversation

morenol
Copy link
Collaborator

@morenol morenol commented Nov 19, 2024

No description provided.

@morenol morenol requested a review from Mec-iS as a code owner November 19, 2024 01:49
@morenol morenol changed the title chore: fix clippy [WIP]: fix clippy Nov 19, 2024
Mec-iS
Mec-iS previously approved these changes Nov 19, 2024
@Mec-iS
Copy link
Collaborator

Mec-iS commented Nov 25, 2024

@morenol what do we do with these doc-empty errors?

@morenol
Copy link
Collaborator Author

morenol commented Nov 25, 2024

@morenol what do we do with these doc-empty errors?

I have trying to fix them but they are a lot and I am not familiar with all of them

@morenol morenol force-pushed the clippy-1-82 branch 2 times, most recently from 3e49a90 to e42332d Compare November 25, 2024 14:01
@morenol morenol force-pushed the clippy-1-82 branch 7 times, most recently from 58143ca to 259ecfc Compare November 25, 2024 14:49
@morenol morenol force-pushed the clippy-1-82 branch 2 times, most recently from 9ea5a2b to ba38a07 Compare November 25, 2024 15:13
@morenol morenol changed the title [WIP]: fix clippy chore: fix clippy Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.51%. Comparing base (239c004) to head (f04359a).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
src/linalg/basic/arrays.rs 0.00% 4 Missing ⚠️
src/cluster/kmeans.rs 25.00% 3 Missing ⚠️
src/algorithm/neighbour/cover_tree.rs 50.00% 2 Missing ⚠️
src/tree/decision_tree_classifier.rs 60.00% 2 Missing ⚠️
src/tree/decision_tree_regressor.rs 66.66% 2 Missing ⚠️
src/algorithm/neighbour/linear_search.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #283      +/-   ##
===============================================
+ Coverage        45.49%   45.51%   +0.01%     
===============================================
  Files               85       85              
  Lines             7254     7306      +52     
===============================================
+ Hits              3300     3325      +25     
- Misses            3954     3981      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@morenol morenol merged commit ba75f9f into smartcorelib:development Nov 25, 2024
14 checks passed
@morenol morenol deleted the clippy-1-82 branch November 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants